Changeset 163

Timestamp:

02/17/09 02:43:08 (3 years ago)

Author:

erik

Message:

This fixes a issue in importing ps zone information. I missed a bug in FL and fixed it in the wrong place.
The FL attribute font.blue_values_num can't be set to the highest number required to store 7 zones. Adam was asked about t his in september 2008, but didn't answer.
While this can't fix the FL bug, it can properly import all values up to the last one. A warning is printed when the last value is dropped.

Files:

• trunk/Lib/robofab/objects/objectsFL.py (modified) (8 diffs)

trunk/Lib/robofab/objects/objectsFL.py

@@ -106 +106 @@
-        stem_snap_v_num(integer)
-        stem_snap_v
+        
+                
+        
- """
-
@@ -151 +154 @@
-        def _asPairs(self, l):
-                """Split a list of numbers into a list of pairs"""
-
+
+
-                n = [[l[i], l[i+1]] for i in range(0, len(l), 2)]
-                n.sort()
@@ -166 +170 @@
-                return n
-        
+        def _checkForFontLabSanity(self, attribute, values):
+                """Function to handle problems with FontLab not allowing the max number of 
+                alignment zones to be set to the max number.
+                Input:  the name of the zones and the values to be set
+                Output: a warning when there are too many values to be set
+                                and the max values which FontLab will allow.
+                """
+                warn = False
+                if attribute in ['vStems', 'hStems']:
+                        # the number of items to drop from the list if the list is too long,
+                        # stems are single values, but the zones are pairs.
+                        skip = 1
+                        total = min(self._attributeNames[attribute]['max'], len(values))
+                        if total == self._attributeNames[attribute]['max']:
+                                total = self._attributeNames[attribute]['max'] - skip
+                                warn = True
+                else:
+                        skip = 2
+                        values = self._flattenPairs(values)
+                        total = min(self._attributeNames[attribute]['max']*2, len(values))
+                        if total == self._attributeNames[attribute]['max']*2:
+                                total = self._attributeNames[attribute]['max']*2 - skip
+                                warn = True
+                if warn:
+                        print "* * * WARNING: FontLab will only accept %d %s items maximum from Python. Dropping values: %s."%(self._attributeNames[attribute]['max']-1, attribute, `values[total:]`)
+                return total, values[:total]
+                
+                
-        def _getBlueValues(self):
-                        return self._asPairs(self._object.blue_values[self._masterIndex])
-        def _setBlueValues(self, values):
-values = self._flattenPairs(
-min(self._attributeNames['blueValues']['max']*2, len(values))-1
-+1
+total, values = self._checkForFontLabSanity('blueValues', 
+total
+
-                        self._object.blue_values[self._masterIndex][i] = values[i]
-
@@ -177 +209 @@
-                        return self._asPairs(self._object.other_blues[self._masterIndex])
-        def _setOtherBlues(self, values):
-values = self._flattenPairs(
-min(self._attributeNames['otherBlues']['max']*2, len(values))-1
-+1
+total, values = self._checkForFontLabSanity('otherBlues', 
+total
+
-                        self._object.other_blues[self._masterIndex][i] = values[i]
-
@@ -185 +217 @@
-                        return self._asPairs(self._object.family_blues[self._masterIndex])
-        def _setFamilyBlues(self, values):
-values = self._flattenPairs(
-min(self._attributeNames['familyBlues']['max']*2, len(values))-1
-+1
+total, values = self._checkForFontLabSanity('familyBlues', 
+total
+
-                        self._object.family_blues[self._masterIndex][i] = values[i]
-
@@ -193 +225 @@
-                        return self._asPairs(self._object.family_other_blues[self._masterIndex])
-        def _setFamilyOtherBlues(self, values):
-values = self._flattenPairs(
-min(self._attributeNames['familyOtherBlues']['max']*2, len(values))-1
-+1
+total, values = self._checkForFontLabSanity('familyOtherBlues', 
+total
+
-                        self._object.family_other_blues[self._masterIndex][i] = values[i]
-
@@ -201 +233 @@
-                        return list(self._object.stem_snap_v[self._masterIndex])
-        def _setVStems(self, values):
-
-
+
+
+
-                        self._object.stem_snap_v[self._masterIndex][i] = values[i]
-
@@ -208 +241 @@
-                        return list(self._object.stem_snap_h[self._masterIndex])
-        def _setHStems(self, values):
-
-
+
+
+
-                        self._object.stem_snap_h[self._masterIndex][i] = values[i]
-